Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: Fix regex for bumping version #589

Merged
merged 3 commits into from
Apr 9, 2020
Merged

ActiveDirectoryDsc: Fix regex for bumping version #589

merged 3 commits into from
Apr 9, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 9, 2020 •
edited by X-Guardian
Loading

Pull Request (PR) description

  • ActiveDirectoryDsc
    • The regular expression for minor-version-bump-message in the file
      GitVersion.yml was changed to only raise minor version when the
      commit message contain the word add, adds, minor, feature,
      or features.
    • Only run CI pipeline on branch master when there are changes to files
      inside the source folder.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Apr 9, 2020
@johlju johlju requested a review from X-Guardian April 9, 2020 13:51
@johlju johlju changed the title ActiveDirectoryDsc: Fix regex for bumping minor version ActiveDirectoryDsc: Fix regex for bumping version Apr 9, 2020
@johlju johlju force-pushed the fix/giversion-minor-bump-regex branch from 7d6d7b9 to 28fa761 Compare April 9, 2020 14:31
@johlju johlju force-pushed the fix/giversion-minor-bump-regex branch from 28fa761 to 8773e49 Compare April 9, 2020 14:32
X-Guardian
X-Guardian approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@X-Guardian X-Guardian removed the needs review The pull request needs a code review. label Apr 9, 2020
@X-Guardian X-Guardian merged commit c5ebb76 into dsccommunity:master Apr 9, 2020
@johlju johlju deleted the fix/giversion-minor-bump-regex branch April 10, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@X-Guardian X-Guardian X-Guardian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActiveDirectoryDsc: To lenient when to raise minor version
2 participants
@johlju @X-Guardian